Conversation
…cast - Remove VersionOverride="43.12.201" from FSharp.Formatting.Markdown.fsproj. The package now uses the central pin ([43.12.202]) from Directory.Packages.props, eliminating the NU1605 (package downgrade) build warning that appeared since the central pin was bumped to 43.12.202 in a later dependabot PR. - Replace Enumerable.Cast<XAttribute> (LINQ) with Seq.cast<XAttribute> (idiomatic F#) in MarkdownUtils.fs, allowing the 'open System.Linq' import to be removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 19, 2026
dsyme
deleted the
repo-assist/improve-fcs-pin-seq-cast-2026-04-18-7bf530223a32aad3
branch
github-actions Bot
added a commit
that referenced
this pull request
Apr 20, 2026
…1 release notes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Two small engineering quality improvements — one build-system fix (Task 4) and one code idiom improvement (Task 5).
1. Fix stale
FSharp.Compiler.ServiceVersionOverride (Task 4 — Engineering Investment)Root cause
A dependabot PR (commit
0c31fe2) bumpedFSharp.Compiler.Serviceto43.12.201and addedVersionOverride="43.12.201"toFSharp.Formatting.Markdown.fsproj. A subsequent dependabot PR then bumped the central pin inDirectory.Packages.propsto[43.12.202], but theVersionOverridewas not updated. This created a version conflict: theFSharp.Formatting.Commonproject (aProjectReferencefrom Markdown) resolved43.12.202, while the directPackageReferencewith the staleVersionOverridetried to pull43.12.201. The result was a NU1605 ("Detected package downgrade") build warning on every restore.Fix
Remove the
VersionOverrideattribute, letting the package use the central pin fromDirectory.Packages.props(43.12.202) consistently across the solution.Effect:
NU1605warning eliminated; FCS version is now consistent across all projects in the solution.2. Replace
Enumerable.Cast<XAttribute>withSeq.cast<XAttribute>(Task 5 — Coding Improvement)In
MarkdownUtils.fs, the single use ofSystem.Linq.Enumerable.Cast<XAttribute>can be replaced with the idiomatic F# equivalentSeq.cast<XAttribute>. This allowsopen System.Linqto be removed from the file — a minor clarity improvement that reduces the surface of imported namespaces.Semantics are identical: both cast the untyped
IEnumerabletoseq<XAttribute>.Changes
src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsprojVersionOverridesrc/FSharp.Formatting.Markdown/MarkdownUtils.fsopen System.Linq; useSeq.castRELEASE_NOTES.mdTest Status
dotnet buildfails in the sandbox environment with "Creating directory obj/..." errors — this is a pre-existing sandbox limitation, not caused by my changes.VersionOverrideremoval was verified:dotnet restoreon the Markdown project now completes cleanly with zero NU1605 warnings.Seq.cast<'T>is the documented F# equivalent ofEnumerable.Cast<'T>— the semantics are identical.Generated by 🤖 Repo Assist, see workflow run.